Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22640 )
Change subject: WIP: Implement in-place reset metadata for CatalogD ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22640/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22640/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@a2325 PS2, Line 2325: > With this atomic set removed, we should be able to finally reimplement dbCa Done http://gerrit.cloudera.org:8080/#/c/22640/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1066 PS2, Line 1066: InvalidateAwareDbSnapshot snapshot = new InvalidateAwareDbSnapshot(getAllDbs()); : for (Db db : snapshot) { : if (db.isRemoved()) continue; : ctx.numDbs++; : addDatabaseToCatalogDelta(db, ctx); : } : for (DataSource dataSource: getAllDataSources()) { : addDataSourceToCatalogDelta(dataSource, ctx); : } : for (HdfsCachePool cachePool: getAllHdfsCachePools()) { : addHdfsCachePoolToCatalogDelta(cachePool, ctx); : } : for (Role role: getAllRoles()) { : addPrincipalToCatalogDelta(role, ctx); : } : for (User user: getAllUsers()) { : addPrincipalToCatalogDelta(user, ctx); : } > We can probably wrap this way of iterating as a new Iterable class, say, I Done http://gerrit.cloudera.org:8080/#/c/22640/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2401 PS2, Line 2401: Collections.sort(allDbs); : resettingDbs_.addAll(allDbs); : long allDbsCount = resettingDbs_.size( > Should measure and log how long reset() is giving up versionLock_.writeLock Done -- To view, visit http://gerrit.cloudera.org:8080/22640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4ae2154612746b34484391c5950e74b61f85c9d Gerrit-Change-Number: 22640 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 22 Mar 2025 00:56:25 +0000 Gerrit-HasComments: Yes
