Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22726 )
Change subject: IMPALA-13929: Make 'functional-query' the default workload in tests ...................................................................... Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/22726/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22726/1/tests/common/impala_test_suite.py@193 PS1, Line 193: The workload affects exploration strategy : # if workload_explora > Added a bit more info and pointed to exploration_strategy() Done http://gerrit.cloudera.org:8080/#/c/22726/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22726/3/tests/common/impala_test_suite.py@1430 PS3, Line 1430: disable_codegen_options = ALL_DISABLE_CODEGEN_OPTIONS : batch_sizes = ALL_BATCH_SIZE Done http://gerrit.cloudera.org:8080/#/c/22726/1/tests/custom_cluster/test_catalog_hms_failures.py File tests/custom_cluster/test_catalog_hms_failures.py: http://gerrit.cloudera.org:8080/#/c/22726/1/tests/custom_cluster/test_catalog_hms_failures.py@157 PS1, Line 157: if cls.exploration_strategy() != 'exhaustive': : pytest.skip('These tests only run in exhaustive') > I wouldn't touch anything else than get_workload() in this patch, as it is Ack -- To view, visit http://gerrit.cloudera.org:8080/22726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ec6c41ffb3a30e1ea2de773626d1485c69fe115 Gerrit-Change-Number: 22726 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 05 Apr 2025 14:24:37 +0000 Gerrit-HasComments: Yes
