Hello Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10556
to review the following change.
Change subject: IMPALA-7091: Address NullPointerException in
HBaseTable.getRegionSize().
......................................................................
IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize().
It's possible for "serverLoad.getRegionsLoad().get(info.getRegionName())"
to be null, which causes a NullPointerException in the planner, and
visible to the user. The code around it already says that it handles
errors by returning 0 for the size, and I've extended that to one more
case.
In practice, I have seen this come up in failures of the following test:
failure.test_failpoints.TestFailpoints.test_failpoints[table_format:
hbase/none | exec_option: {'batch_size': 0, 'num_nodes': 0,
'disable_codegen_rows_threshold': 0, 'disable_codegen': False,
'abort_on_error': 1, 'debug_action': None, 'exec_single_node_rows_threshold':
0} | mt_dop: 4 | location: OPEN | action: MEM_LIMIT_EXCEEDED | query: select *
from alltypessmall union all select * from alltypessmall]
I saw this failure only happen in some test-with-docker runs,
inconsistently. The error is a little bit hard to spot, but by
correlating the timestamp of the failing test (which just complains
about NullPointerException), you can find a Java stack trace complaining
of a NPE in "regionLoad.getStorefileSizeMB()". I think the likely cause
is regionLoad being null.
Change-Id: I02f06daf69e7f7e97c9ecc13997147530c2f9d3f
Reviewed-on: http://gerrit.cloudera.org:8080/10531
Reviewed-by: Joe McDonnell <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
(cherry picked from commit fc0c5f58f00b360a7651187e0b0fe79add426742)
---
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/10556/1
--
To view, visit http://gerrit.cloudera.org:8080/10556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02f06daf69e7f7e97c9ecc13997147530c2f9d3f
Gerrit-Change-Number: 10556
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
