Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/22671 )
Change subject: IMPALA-13893: Add node id to the file name in tuple cache
correctness verification
......................................................................
IMPALA-13893: Add node id to the file name in tuple cache correctness
verification
Currently, the file name for tuple cache correctness verification
was generated using only the fragment instance id. However, in
some cases, multiple tuple cache nodes within the same fragment
instance may share the same cache key, leading to conflicts
during file comparison.
This patch resolves the issue by appending the node id to the file
name, make sure it is unique among nodes within the same fragment
instance.
Old Format:
file: {fragment_instance_id}
Ref file: {fragment_instance_id}_{org_fragment_instance_id}_ref
New Format:
file: {fragment_instance_id}_{node_id}
Ref file: {fragment_instance_id}_{node_id}
_{org_fragment_instance_id}_{node_id}_ref
Tests:
Passed query_test.test_queries.TestQueriesTextTables.test_random,
which previously failed due to this issue.
Change-Id: I6ce5ed05623761ace7b7a1027b762736a63e97fc
Reviewed-on: http://gerrit.cloudera.org:8080/22671
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
---
M be/src/exec/tuple-cache-node.cc
1 file changed, 14 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ce5ed05623761ace7b7a1027b762736a63e97fc
Gerrit-Change-Number: 22671
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
