Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22746 )
Change subject: IMPALA-13873: Missing equivalence conjunct in aggregation node with inline views ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/22746/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22746/6//COMMIT_MSG@62 PS6, Line 62: https://github.com/apache/impala/blob/6f2d9a24d8c014a7dc1ec7a08bcfb025b3bdf41f/testdata/workloads/functional-planner/queries/PlannerTest/union.test#L3914 nit: Can be shorter https://github.com/apache/impala/blob/6f2d9a2/testdata/workloads/functional-planner/queries/PlannerTest/union.test#L3914 http://gerrit.cloudera.org:8080/#/c/22746/6/testdata/workloads/functional-planner/queries/PlannerTest/union.test File testdata/workloads/functional-planner/queries/PlannerTest/union.test: http://gerrit.cloudera.org:8080/#/c/22746/6/testdata/workloads/functional-planner/queries/PlannerTest/union.test@4637 PS6, Line 4637: # Regression test for IMPALA-13873: the conjunct 'b = min_b' in the aggregation node : # should not be discarded. : WITH u1 AS (select 10 a, 10 b), : t AS (select a, b, min(b) over (partition by a) min_b from u1 UNION select 10, 10, 20) : select t.* from t where t.b = t.min_b; Can you please add test that: - Scan over real table (maybe pick one from functional Db). - Union node has at least 2 children. - Unlike https://github.com/apache/impala/blob/6f2d9a2/testdata/workloads/functional-planner/queries/PlannerTest/union.test#L3914, the predicate must not be pushed down to the children nodes. -- To view, visit http://gerrit.cloudera.org:8080/22746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67a59cd96d83181ce249fd6ca141906f549a09b3 Gerrit-Change-Number: 22746 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Apr 2025 15:28:25 +0000 Gerrit-HasComments: Yes
