Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22761 )
Change subject: IMPALA-13932: Add file path and position-based duplicate check for IcebergMergeNode ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22761/3/be/src/exec/iceberg-merge-node.cc File be/src/exec/iceberg-merge-node.cc: http://gerrit.cloudera.org:8080/#/c/22761/3/be/src/exec/iceberg-merge-node.cc@284 PS3, Line 284: _ nit: underscore not needed http://gerrit.cloudera.org:8080/#/c/22761/3/be/src/exec/iceberg-merge-node.cc@299 PS3, Line 299: void IcebergMergeNode::SavePreviousRowPtrAndIdent(TupleRow* actual_row) { : impala_udf::StringVal file_path_sv = : delete_meta_evaluators_[0]->GetStringVal(actual_row); : auto file_pos = delete_meta_evaluators_[1]->GetBigIntVal(actual_row); target tuple can be a nullptr in case of WHEN NOT MATCHED BY TARGET, so probably we'll get segfaults in this funcion -- To view, visit http://gerrit.cloudera.org:8080/22761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71b47414321675958c05438ef3aeeb5df0128033 Gerrit-Change-Number: 22761 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 08 Apr 2025 19:04:28 +0000 Gerrit-HasComments: Yes
