Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17265 )

Change subject: [PROTOTYPE] IMPALA-10630: Support negative compression levels 
for ZSTD
......................................................................


Patch Set 5:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/17265/5/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/17265/5/testdata/bin/generate-schema-statements.py@525
PS5, Line 525: def build_insert(insert, db_name, db_suffix, file_format, codec, 
compression_type,
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17265/5/tests/benchmark/report_benchmark_results.py
File tests/benchmark/report_benchmark_results.py:

http://gerrit.cloudera.org:8080/#/c/17265/5/tests/benchmark/report_benchmark_results.py@437
PS5, Line 437:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/5/tests/benchmark/report_benchmark_results.py@437
PS5, Line 437:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/5/tests/benchmark/report_benchmark_results.py@476
PS5, Line 476:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/5/tests/benchmark/report_benchmark_results.py@476
PS5, Line 476:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/5/tests/benchmark/report_benchmark_results.py@1057
PS5, Line 1057:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/5/tests/benchmark/report_benchmark_results.py@1057
PS5, Line 1057:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/5/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:

http://gerrit.cloudera.org:8080/#/c/17265/5/tests/common/test_dimensions.py@76
PS5, Line 76: l
flake8: E501 line too long (94 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17265/5/tests/common/test_dimensions.py@80
PS5, Line 80: c
flake8: F841 local variable 'compression_level_int' is assigned to but never 
used


http://gerrit.cloudera.org:8080/#/c/17265/5/tests/common/test_dimensions.py@114
PS5, Line 114: e
flake8: E501 line too long (95 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/17265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10a7657a479610ccb551162dd8d1247fd2514a6d
Gerrit-Change-Number: 17265
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 15 Apr 2025 21:27:30 +0000
Gerrit-HasComments: Yes

Reply via email to