Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22774 )

Change subject: IMPALA-13959: Fix 
TestHmsIntegration.test_change_parquet_column_type
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22774/2/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:

http://gerrit.cloudera.org:8080/#/c/22774/2/tests/metadata/test_hms_integration.py@a300
PS2, Line 300:
> If no test require vector fixture, then no need to override add_test_dimens
Thanks Riza! It's clearer for me now.



--
To view, visit http://gerrit.cloudera.org:8080/22774
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5fb9f96b4087e86b0ebaac7135e14b7a14936ea
Gerrit-Change-Number: 22774
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Thu, 17 Apr 2025 01:29:02 +0000
Gerrit-HasComments: Yes

Reply via email to