Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10550 )
Change subject: IMPALA-7078: improve memory consumption of wide Avro scans ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10550/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10550/2//COMMIT_MSG@18 PS2, Line 18: Cap the maximum row batch queue size at 5 * the number of active : scanner threads. > I did some benchmarks and the dynamic queue size caused performance changes I'm not opposed to doing this. I was more questioning whether the old heuristic makes any sense or if we should just rethink the sizing entirely (rather than add on top of the confusion). -- To view, visit http://gerrit.cloudera.org:8080/10550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebd2600b4784fd19696c9b92eefb7d7e9db0c80b Gerrit-Change-Number: 10550 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 01 Jun 2018 16:11:53 +0000 Gerrit-HasComments: Yes
