Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10575 )

Change subject: IMPALA-7109: fix test_multiple_partitions_same_location paths
......................................................................


Patch Set 1:

(1 comment)

Was looking at IMPALA-6119, so had a look at this since it's somewhat related. 
Fix makes sense, just one question.

http://gerrit.cloudera.org:8080/#/c/10575/1/tests/metadata/test_partition_metadata.py
File tests/metadata/test_partition_metadata.py:

http://gerrit.cloudera.org:8080/#/c/10575/1/tests/metadata/test_partition_metadata.py@52
PS1, Line 52: qualified_path
Why 'qualified_path' ? Wouldn't TBL_LOCATION work for local as well since 
WAREHOUSE would point to the appropriate local warehouse location?



--
To view, visit http://gerrit.cloudera.org:8080/10575
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fc0b2aa2e82bfd8224c52546683f23de20cb640
Gerrit-Change-Number: 10575
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Fri, 01 Jun 2018 17:39:09 +0000
Gerrit-HasComments: Yes

Reply via email to