Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22815 )
Change subject: IMPALA-13991: Skip CROSS_JOIN rewrite if subquery is in disjunctive ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test File testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test: http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test@344 PS4, Line 344: 03:NESTED LOOP JOIN [LEFT OUTER JOIN, BROADCAST] > Both hand of join has the same name, but they are different SlotRef. Ack http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test: http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test@4112 PS4, Line 4112: where (t.int_col = 0 or > I can add this as separate one, but this test case plan will change anyway. Ack -- To view, visit http://gerrit.cloudera.org:8080/22815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac0deb0b2fb1536684cce2e004156a20b769b9ab Gerrit-Change-Number: 22815 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Fri, 25 Apr 2025 21:12:36 +0000 Gerrit-HasComments: Yes
