Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22105 )
Change subject: IMPALA-13517: Support overloaded || operator ...................................................................... Patch Set 10: Code-Review+1 (1 comment) This is making sense to me http://gerrit.cloudera.org:8080/#/c/22105/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConcatOrOperator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConcatOrOperator.java: http://gerrit.cloudera.org:8080/#/c/22105/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConcatOrOperator.java@67 PS10, Line 67: return SqlOperandCountRanges.between(2, 3); Nit: Should this be between(2, 2)? The max value is inclusive. -- To view, visit http://gerrit.cloudera.org:8080/22105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabaf02e84b769db1419bd96e1d1b30b8f83d56f5 Gerrit-Change-Number: 22105 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 25 Apr 2025 21:30:56 +0000 Gerrit-HasComments: Yes
