Kurt Deschler has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22840 )

Change subject: IMPALA-14006: Bound max_instances in 
CreateInputCollocatedInstances
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/22840/2/be/src/scheduling/scheduler.cc
File be/src/scheduling/scheduler.cc:

http://gerrit.cloudera.org:8080/#/c/22840/2/be/src/scheduling/scheduler.cc@933
PS2, Line 933:           "$0 lowered max_instance from $1 to $2 due to 
num_host=$3 and "
Add "Fragment " prefix


http://gerrit.cloudera.org:8080/#/c/22840/2/fe/src/main/java/org/apache/impala/planner/PlanFragment.java
File fe/src/main/java/org/apache/impala/planner/PlanFragment.java:

http://gerrit.cloudera.org:8080/#/c/22840/2/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1138
PS2, Line 1138:         LOG.warn("Forcing {} scale down from {} to {} to follow 
left-child node "
Change wording to "Reducing Executor count.."


http://gerrit.cloudera.org:8080/#/c/22840/2/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1219
PS2, Line 1219:     PARTITIONED_JOIN_BUILD,
Try to make these names explain the bounding factor better and it is an upper 
or lower bound. Especially PARTITIONED_JOIN_BUILD.



--
To view, visit http://gerrit.cloudera.org:8080/22840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65223b820c9fd6e4267d57297b1466d4e56829b3
Gerrit-Change-Number: 22840
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Comment-Date: Thu, 01 May 2025 13:01:27 +0000
Gerrit-HasComments: Yes

Reply via email to