Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22831 )

Change subject: IMPALA-11672: Update 'transient_lastDdlTime' for Iceberg tables
......................................................................


Patch Set 5:

(4 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22831/5/tests/metadata/test_last_ddl_time_update.py
File tests/metadata/test_last_ddl_time_update.py:

http://gerrit.cloudera.org:8080/#/c/22831/5/tests/metadata/test_last_ddl_time_update.py@197
PS5, Line 197: v
flake8: U100 Unused argument 'vector'


http://gerrit.cloudera.org:8080/#/c/22831/5/tests/metadata/test_last_ddl_time_update.py@236
PS5, Line 236: v
flake8: U100 Unused argument 'vector'


http://gerrit.cloudera.org:8080/#/c/22831/5/tests/metadata/test_last_ddl_time_update.py@263
PS5, Line 263: v
flake8: U100 Unused argument 'vector'


http://gerrit.cloudera.org:8080/#/c/22831/5/tests/metadata/test_last_ddl_time_update.py@291
PS5, Line 291: v
flake8: U100 Unused argument 'vector'



--
To view, visit http://gerrit.cloudera.org:8080/22831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e5f63b50bd37c80faf482c4baf4221be857c54b
Gerrit-Change-Number: 22831
Gerrit-PatchSet: 5
Gerrit-Owner: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 09 May 2025 16:41:54 +0000
Gerrit-HasComments: Yes

Reply via email to