Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22883 )
Change subject: IMPALA-13982: [WIP] Support views for Calcite planner in Impala ...................................................................... Patch Set 1: (8 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22883/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java: http://gerrit.cloudera.org:8080/#/c/22883/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java@85 PS1, Line 85: super(reader, table.getName().toUpperCase(), buildColumnsForRelDataType(table)); // fang-yu: should we uppercase the table name? line too long (132 > 90) http://gerrit.cloudera.org:8080/#/c/22883/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java@88 PS1, Line 88: .stream().map(String::toUpperCase).collect(Collectors.toList()); // fang-yu: should we uppercase it? line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/22883/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java: http://gerrit.cloudera.org:8080/#/c/22883/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@176 PS1, Line 176: dbSchemas.getOrDefault(tableName.getDb().toUpperCase(), new CalciteDb.Builder(reader)); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22883/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@202 PS1, Line 202: CalciteSchema schema = rootSchema.getSubSchema(tableName.getDb().toUpperCase(), false); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22883/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@203 PS1, Line 203: // we need to set 'modifiable' to false instead of null to pass the query validation. line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22883/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@205 PS1, Line 205: new ViewTableMacro(schema, ((FeView) feTable).getQueryStmt().toSql().toUpperCase(), line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22883/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@207 PS1, Line 207: ImmutableList.of(feTable.getDb().getName().toUpperCase(), feTable.getName().toUpperCase()), /* modifiable */ false); line too long (132 > 90) http://gerrit.cloudera.org:8080/#/c/22883/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@208 PS1, Line 208: schema.plus().add(feTable.getName().toUpperCase(), viewTableMacro); // fang-yu: try uppercase it too. line too long (109 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I600aae816727ae942fb221fae84c2aac63ae1893 Gerrit-Change-Number: 22883 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 12 May 2025 20:49:09 +0000 Gerrit-HasComments: Yes
