Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22893 )
Change subject: IMPALA-14069: Factor possibility of zero timestamps in aggregated event sequences ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/22893/1/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/22893/1/be/src/util/runtime-profile.cc@3046 PS1, Line 3046: -1 Consider creating a constant for this -1 and use it everywhere else. const int64_t MISSING_TIMESTAMP = -1; http://gerrit.cloudera.org:8080/#/c/22893/1/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.pretty.json File testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.pretty.json: http://gerrit.cloudera.org:8080/#/c/22893/1/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.pretty.json@a2563 PS1, Line 2563: Was this a bug? -- To view, visit http://gerrit.cloudera.org:8080/22893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f1efd2aad5f62084075cd8f9169ef72c66942b6 Gerrit-Change-Number: 22893 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 13 May 2025 15:50:26 +0000 Gerrit-HasComments: Yes
