Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22900
Change subject: IMPALA-14049: Fix TSAN issue with HdrHistogram in expr-test ...................................................................... IMPALA-14049: Fix TSAN issue with HdrHistogram in expr-test IMPALA-13978 switched HdrHistrogram from using a gscoped_ptr to unique_ptr. This has been causing TSAN issues during the teardown for expr-test. gscoped_ptr doesn't null out the pointer when it gets destructed, but unique_ptr does. This is a data race with the threads that are still running and trying to access the metrics. The full solution would be to have an orderly shutdown of all the threads before destructing things. That is a large project that would touch many different components. As a short-term fix, this avoids the TSAN issue by leaking the statestore metrics. We should consider fixing IMPALA-9314 and implementing orderly shutdown. Testing: - Ran expr-test in a loop with TSAN and didn't see this particular issue. There are other shutdown issues with much lower frequency that have different symptoms. Change-Id: I73c3f4db16c6ffa272f2512e9871db5743be7a54 --- M be/src/exprs/expr-test.cc 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/22900/1 -- To view, visit http://gerrit.cloudera.org:8080/22900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I73c3f4db16c6ffa272f2512e9871db5743be7a54 Gerrit-Change-Number: 22900 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]>
