Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22883 )
Change subject: IMPALA-13982: Support views for Calcite planner in Impala ...................................................................... Patch Set 9: (2 comments) I'm not expert in Calcite planner yet. So I can only gave general feedback. http://gerrit.cloudera.org:8080/#/c/22883/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22883/9//COMMIT_MSG@9 PS9, Line 9: regular views Can you elaborate what is regular view vs non-regular view? Please give example of view query that is not covered yet. http://gerrit.cloudera.org:8080/#/c/22883/9/java/calcite-planner/pom.xml File java/calcite-planner/pom.xml: http://gerrit.cloudera.org:8080/#/c/22883/9/java/calcite-planner/pom.xml@45 PS9, Line 45: This prevents calcite-core from using avatica-core that does not shade its : dependencies like protobuf-java during regular view expansion. Please also mention what library what we want to avoid pulling by adding this exclusion. -- To view, visit http://gerrit.cloudera.org:8080/22883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I600aae816727ae942fb221fae84c2aac63ae1893 Gerrit-Change-Number: 22883 Gerrit-PatchSet: 9 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 15 May 2025 22:18:02 +0000 Gerrit-HasComments: Yes
