Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22871 )
Change subject: IMPALA-12162: Checksum files before lock in INSERT ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a7843 PS3, Line 7843: : : : : Are these dead codes so being removed? http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7306 PS3, Line 7306: Map<String, Pair<String, String>> fileMetadata = getFileInsertMetadata( : (FeFsTable)table, update.getUpdated_partitions().values()); : catalogTimeline.markEvent("Collected file checksums"); We don't need the checksums if shouldGenerateInsertEvents(table) returns false. http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7814 PS3, Line 7814: // Returns a map of file name to checksum and acidDirPath. nit: use "/** */" type comments like other methods. http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7843 PS3, Line 7843: List<String> newFiles, Map<String, Pair<String, String>> fileInsertMetadata, nit: need a method comment to explain what are in 'fileInsertMetadata'. http://gerrit.cloudera.org:8080/#/c/22871/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7852 PS3, Line 7852: if (metadata.first != null) { Could you comment on what scenarios have null checksums? If some files have null checksums, the list of filesAddedChecksum is inconsistent with filesAdded. -- To view, visit http://gerrit.cloudera.org:8080/22871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18f9686f5d53cf1e7c384684c25427fb5353e2af Gerrit-Change-Number: 22871 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 16 May 2025 11:44:37 +0000 Gerrit-HasComments: Yes
