Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22861 )
Change subject: IMPALA-14031: Enable keepalive by default for client connections ...................................................................... IMPALA-14031: Enable keepalive by default for client connections Keepalive is useful for detecting dead client connections. In particular, it has come up several times with load balancers that drop idle connections. In IMPALA-13253, we added startup flags that can turn on keepalive and tune the timeouts, but that change did not enable keepalive by default. This enables keepalive by default by setting client_keepalive_probe_period_s to 10 minutes / 600 seconds. The usual OS setting has a probe period of 2 hours / 7200 seconds. This uses a more aggressive default, because a client connection counts towards the fe_service_threads limit. Detecting dead clients quickly frees up those threads. This has no impact on idle connections where the TCP connection is still alive. That is handled through separate controls. Testing: - There is already a custom cluster test for keepalive that continues to pass - Ran core tests Change-Id: Ie358b5cabaff884516f7117d20d18c25124e59d5 Reviewed-on: http://gerrit.cloudera.org:8080/22861 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Riza Suminto <[email protected]> --- M be/src/service/impala-server.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Michael Smith: Looks good to me, but someone else must approve Riza Suminto: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie358b5cabaff884516f7117d20d18c25124e59d5 Gerrit-Change-Number: 22861 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
