Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22914 )
Change subject: IMPALA-14081: Support create/drop paimon table for impala ...................................................................... Patch Set 2: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22914/2/fe/src/main/java/org/apache/impala/analysis/paimon/PaimonAnalyzer.java File fe/src/main/java/org/apache/impala/analysis/paimon/PaimonAnalyzer.java: http://gerrit.cloudera.org:8080/#/c/22914/2/fe/src/main/java/org/apache/impala/analysis/paimon/PaimonAnalyzer.java@61 PS2, Line 61: "Can't specify 'partition' table property in Paimon DDL, use PARTITIONED BY clause instead."); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/22914/2/fe/src/main/java/org/apache/impala/analysis/paimon/PaimonAnalyzer.java@66 PS2, Line 66: "Can't specify both PRIMARY KEY clause and 'primary-key' table property in Paimon DDL."); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/22914/2/fe/src/main/java/org/apache/impala/analysis/paimon/PaimonAnalyzer.java@152 PS2, Line 152: // stmt.getTblProperties().containsKey(CoreOptions.PRIMARY_KEY.key()) line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22914/2/fe/src/main/java/org/apache/impala/analysis/paimon/PaimonAnalyzer.java@154 PS2, Line 154: // stmt.getTblProperties().containsKey(CoreOptions.BUCKET.key()) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22914/2/fe/src/main/java/org/apache/impala/analysis/paimon/PaimonAnalyzer.java@156 PS2, Line 156: // stmt.getTblProperties().containsKey(CoreOptions.BUCKET_KEY.key()) line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22914/2/fe/src/main/java/org/apache/impala/catalog/paimon/FePaimonTable.java File fe/src/main/java/org/apache/impala/catalog/paimon/FePaimonTable.java: http://gerrit.cloudera.org:8080/#/c/22914/2/fe/src/main/java/org/apache/impala/catalog/paimon/FePaimonTable.java@102 PS2, Line 102: "Failed to load column stats for %s, column %s. Stats may be incompatible with column type %s. " line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/22914/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22914/2/fe/src/main/java/org/apache/impala/service/Frontend.java@22 PS2, Line 22: import static org.apache.impala.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService.ROOT_POOL_NAME; line too long (118 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57e77f28151e4a91353ef77050f9f0cd7d9d05ef Gerrit-Change-Number: 22914 Gerrit-PatchSet: 2 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 20 May 2025 08:01:27 +0000 Gerrit-HasComments: Yes
