Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 )
Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/10478/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10478/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3486 PS5, Line 3486: if (params.getDb() != null) { pls add preconditions to check that exactly one of db or table is set (both set or none set is an error). http://gerrit.cloudera.org:8080/#/c/10478/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3554 PS5, Line 3554: tbl.setCatalogVersion(newCatalogVersion); loadTableMetadata sets the catalog version, so this line can be removed. -- To view, visit http://gerrit.cloudera.org:8080/10478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I497c17342f79ff7c99931fd8a0ddec0c79303dbf Gerrit-Change-Number: 10478 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 17:58:52 +0000 Gerrit-HasComments: Yes
