Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22942 )
Change subject: IMPALA-14094: Calcite planner: Use table and column statistics for optimization ...................................................................... Patch Set 2: (15 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java: http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@47 PS2, Line 47: protected static final Logger LOG = LoggerFactory.getLogger(FilterSelectivityEstimator.class); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@156 PS2, Line 156: * Note that = is considered a generic function and uses this method to find its selectivity. line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java: http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java@44 PS2, Line 44: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaRelMdDistinctRowCount.class.getName()); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java@47 PS2, Line 47: .reflectiveSource(BuiltInMethod.DISTINCT_ROW_COUNT.method, new ImpalaRelMdDistinctRowCount()); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java@70 PS2, Line 70: public Double getDistinctRowCount(Aggregate rel, RelMetadataQuery mq, ImmutableBitSet groupKey, line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java@82 PS2, Line 82: public Double getDistinctRowCount(Filter rel, RelMetadataQuery mq, ImmutableBitSet groupKey, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java@102 PS2, Line 102: public Double getDistinctRowCount(Join rel, RelMetadataQuery mq, ImmutableBitSet groupKey, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java: http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java@48 PS2, Line 48: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaRelMdRowCount.class.getName()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSelectivity.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSelectivity.java: http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSelectivity.java@45 PS2, Line 45: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaRelMdSelectivity.class.getName()); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSize.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSize.java: http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdSize.java@61 PS2, Line 61: avgSize = averageTypeValueSize(table.getRowType().getFieldList().get(i).getType()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java: http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java@50 PS2, Line 50: protected static final Logger LOG = LoggerFactory.getLogger(JoinRelationInfo.class.getName()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java@100 PS2, Line 100: if (join_.getJoinType() == JoinRelType.LEFT || join_.getJoinType() == JoinRelType.FULL) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java@104 PS2, Line 104: if (join_.getJoinType() == JoinRelType.RIGHT || join_.getJoinType() == JoinRelType.FULL) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java@147 PS2, Line 147: ImmutableBitSet leftCols = RelOptUtil.InputFinder.bits(((RexCall) joinCond).getOperands().get(0)); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/22942/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/JoinRelationInfo.java@148 PS2, Line 148: ImmutableBitSet rightCols = RelOptUtil.InputFinder.bits(((RexCall) joinCond).getOperands().get(1)); line too long (103 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8daa7e33ae7b819d59848c247f329a8049e034d Gerrit-Change-Number: 22942 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 23 May 2025 16:02:29 +0000 Gerrit-HasComments: Yes
