Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22944 )
Change subject: IMPALA_14095: Calcite Planner: Use pruned row counts in stats ...................................................................... Patch Set 4: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22944/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java: http://gerrit.cloudera.org:8080/#/c/22944/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdRowCount.java@129 PS4, Line 129: Double selectivity = condition != null ? estimator.estimateSelectivity(condition) : 1.0; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22944/4/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java File java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java: http://gerrit.cloudera.org:8080/#/c/22944/4/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java@332 PS4, Line 332: PrunedPartitionHelper helper = table.getPrunedPartitionHelper(condition, rexBuilder); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22944/4/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java@363 PS4, Line 363: PrunedPartitionHelper helper = table.getPrunedPartitionHelper(condition, rexBuilder); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc007ea9ab2d60390c32390612ae4c269cb1b192 Gerrit-Change-Number: 22944 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 23 May 2025 16:22:39 +0000 Gerrit-HasComments: Yes
