Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22947 )

Change subject: IMPALA-14097: Fix test_log_fragments.py
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22947/1/tests/observability/test_log_fragments.py
File tests/observability/test_log_fragments.py:

http://gerrit.cloudera.org:8080/#/c/22947/1/tests/observability/test_log_fragments.py@40
PS1, Line 40:     result = self.hs2_client.execute("select count(*) from 
functional.alltypes")
Do we need to explicitly use "hs2_client"? I thought execute_query() will use 
it if the default protocol is HS2.


http://gerrit.cloudera.org:8080/#/c/22947/1/tests/observability/test_log_fragments.py@53
PS1, Line 53: \
> flake8: W605 invalid escape sequence '\('
might need to use raw string r"..."



--
To view, visit http://gerrit.cloudera.org:8080/22947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93e1fb6c7ba50f47023ca0c382a884093187b847
Gerrit-Change-Number: 22947
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 27 May 2025 02:48:50 +0000
Gerrit-HasComments: Yes

Reply via email to