Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/22554 )
Change subject: IMPALA-13593: Enable event processor to consume ALTER_PARTITIONS events from metastore ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/22554/3/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/22554/3/bin/impala-config.sh@239 PS3, Line 239: 7.3.1.500-3 > Can we use a newer version like 7.3.1.200-90? I recently hit the bug fixed Ack http://gerrit.cloudera.org:8080/#/c/22554/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22554/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@51 PS3, Line 51: import org.apache.hadoop.hive.metastore.messaging.AlterPartitionsMessage; > Is this a problem when building on Apache Hive 3? We probably need to wrap I'm not introducing new APIs, we hit the same old alter_partitions() API but the internal working is tweaked to fire ALTER_PARTITIONS event based on a config in metastore. So it'll not be a problem with HIVE 3 if we are using the bin/impala-config.sh present in this patch. http://gerrit.cloudera.org:8080/#/c/22554/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2888 PS3, Line 2888: " FOR TRANSACTIONAL T > nit: use getEventDesc() to also show the event id. Ack http://gerrit.cloudera.org:8080/#/c/22554/3/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/22554/3/tests/custom_cluster/test_events_custom_configs.py@1671 PS3, Line 1671: event_found = True > nit: add an else-clause to log the event to ease debug in the future. Ack http://gerrit.cloudera.org:8080/#/c/22554/3/tests/custom_cluster/test_events_custom_configs.py@1676 PS3, Line 1676: # self.client.execute(":event_processor('pause')") > stale comment Ack http://gerrit.cloudera.org:8080/#/c/22554/3/tests/custom_cluster/test_events_custom_configs.py@1679 PS3, Line 1679: # self.client.execute(":event_processor('start')") > stale comment Ack http://gerrit.cloudera.org:8080/#/c/22554/3/tests/custom_cluster/test_events_custom_configs.py@1686 PS3, Line 1686: event_found = True > nit: Also add an else-clause here to log the event Ack -- To view, visit http://gerrit.cloudera.org:8080/22554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I009a87ef5e2c331272f9e2d7a6342cc860e64737 Gerrit-Change-Number: 22554 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Tue, 27 May 2025 21:55:41 +0000 Gerrit-HasComments: Yes
