Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22953 )
Change subject: IMPALA-13326: Prefer python3 for tarball packaged impala-shell ...................................................................... IMPALA-13326: Prefer python3 for tarball packaged impala-shell The tarball packaging for impala-shell ships support for multiple Python versions (including both Python 2 and Python 3). In the impala-shell script, it determines the python to use and uses the corresponding installation. Historically, impala-shell has preferred the "python" executable (which can be Python 2) to the "python3" executable. Since Python 2 is deprecated, this flips the preference to prefer "python3" to "python". This continues to respect IMPALA_PYTHON_EXECUTABLE as before, but it adds an IMPALA_SHELL_PYTHON_FALLBACK variable to determine whether to fall back to the regular logic. This defaults to true, allowing fallback, to maintain existing behavior. The shell end-to-end tests set this to false to lock in the Python version. Testing: - Ran shell tests Change-Id: If0e32e8eee672e4dc66e725722f5150cd1e4c9a6 Reviewed-on: http://gerrit.cloudera.org:8080/22953 Reviewed-by: Riza Suminto <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> --- M shell/packaging/impala-shell M tests/shell/util.py 2 files changed, 34 insertions(+), 6 deletions(-) Approvals: Riza Suminto: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Michael Smith: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If0e32e8eee672e4dc66e725722f5150cd1e4c9a6 Gerrit-Change-Number: 22953 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
