Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22914 )
Change subject: IMPALA-14081: Support create/drop paimon table for impala ...................................................................... Patch Set 6: (3 comments) Thank you for contributing this feature to Apache Impala! We should look for more reviewers from Apache Impala community. I just have few questions for now. http://gerrit.cloudera.org:8080/#/c/22914/6/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/22914/6/bin/impala-config.sh@289 PS6, Line 289: export IMPALA_PAIMON_VERSION=1.0.0 How often we need to change version? I see current released version is actually 1.1.1. Why stick with 1.0.0 here? https://paimon.apache.org/releases/1.1.1 http://gerrit.cloudera.org:8080/#/c/22914/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/22914/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@20 PS6, Line 20: import com.codahale.metrics.Histogram; : import com.codahale.metrics.Snapshot; : import com.codahale.metrics.UniformReservoir; : import com.google.common.base.Joiner; : import com.google.common.base.Preconditions; : import com.google.common.base.Predicates; : import com.google.common.cache.Cache; : import com.google.common.cache.CacheBuilder; : import com.google.common.collect.ImmutableList; : import com.google.common.collect.Lists; : import com.google.common.collect.Sets; Please minimize import reordering and keep the old grouping for now. Impala source code has been around for long time, and big changes like this will make it difficult to do backports. http://gerrit.cloudera.org:8080/#/c/22914/6/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/22914/6/testdata/datasets/functional/functional_schema_template.sql@4800 PS6, Line 4800: paimon_non_partitioned Is the current dataset (testdata/data/paimon_test/paimon_catalog/warehouse/functional.db/paimon_non_partitioned/bucket-0/data-c8f2e95a-29ab-4c48-81f0-759337368f9b-0.parquet) an absolute minimal? Can it be lower than 4MB but still serve test code well? -- To view, visit http://gerrit.cloudera.org:8080/22914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57e77f28151e4a91353ef77050f9f0cd7d9d05ef Gerrit-Change-Number: 22914 Gerrit-PatchSet: 6 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 29 May 2025 01:03:22 +0000 Gerrit-HasComments: Yes
