Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests ...................................................................... Patch Set 9: Code-Review+2 (2 comments) LGTM. Carry forward Riza and Joe's votes and adding mine. http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java: http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@69 PS9, Line 69: private static TQueryOptions options = > There is no fallback logic right now for Calcite, so the tests will fail. Done http://gerrit.cloudera.org:8080/#/c/22864/9/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@70 PS9, Line 70: tpcdsParquetQueryOptions() > Filed IMPALA-14113 Done -- To view, visit http://gerrit.cloudera.org:8080/22864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf Gerrit-Change-Number: 22864 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 29 May 2025 16:21:58 +0000 Gerrit-HasComments: Yes
