Halim Kim has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22971 )

Change subject: IMPALA-14066 (Part 4): Re-applying IMPALA-12318: Add a flag 
option for http spnego dedicated keytab file.
......................................................................


Patch Set 2:

It has been a long time since I worked on this task.
Thank you for reminding me
Maybe you already know that same feature is applied to kudu.
(please refer this commit 
-https://github.com/apache/kudu/commit/cdbe4577a91a171718ff485acc1dd1261e73a8d2)
In my opinion, it would be more clear and better to put 
krb5_gss_register_acceptor_identity function in the Webserver::Start() function 
like I did in Kudu. if you stick to original method, 
krb5_gss_register_acceptor_identity will be called every time runspnego is 
executed.
what do you think?


--
To view, visit http://gerrit.cloudera.org:8080/22971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1db5a9f222f74429fead81ec9888bdd5b6e32f48
Gerrit-Change-Number: 22971
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Halim Kim <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Mon, 02 Jun 2025 12:09:22 +0000
Gerrit-HasComments: No

Reply via email to