Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/22869 )
Change subject: IMPALA-14051: Use batch insert HMS API to fire insert events ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/22869/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22869/2//COMMIT_MSG@10 PS2, Line 10: HMS API addWriteNotificationLogInBatch() > "HMS API addWriteNotificationLogInBatch() available starting from Hive 4." Ack http://gerrit.cloudera.org:8080/#/c/22869/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/22869/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@440 PS2, Line 440: Fires a listener event of the type ACID_WRITE on a transactional table in metastore. > Is this improvement limited to Hive ACID table? If yes, please mention it i Ack http://gerrit.cloudera.org:8080/#/c/22869/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@457 PS2, Line 457: req > nit: "req" is better. Ack http://gerrit.cloudera.org:8080/#/c/22869/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@462 PS2, Line 462: sb.append(insertData.getPartitionVal()); > The partition value is added without any proper delimiter, curious what it Consider the table has a partition spec: (String year, int id) It would look something like this: (["2024", 1],["2025", 1],["2026",1]) http://gerrit.cloudera.org:8080/#/c/22869/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@466 PS2, Line 466: batc > nit: "batchedReq" is better. Ack -- To view, visit http://gerrit.cloudera.org:8080/22869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff4a2691631fe9e9e1dc07714c69580a4ace6a8b Gerrit-Change-Number: 22869 Gerrit-PatchSet: 3 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 03 Jun 2025 05:08:32 +0000 Gerrit-HasComments: Yes
