Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23005 )
Change subject: [PROTOTYPE] Modify FrontendFixture to support the Calcite compiler factory ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23005/1/fe/src/test/java/org/apache/impala/common/FrontendFixture.java File fe/src/test/java/org/apache/impala/common/FrontendFixture.java: http://gerrit.cloudera.org:8080/#/c/23005/1/fe/src/test/java/org/apache/impala/common/FrontendFixture.java@404 PS1, Line 404: ParsedStatement parsedStmt = compilerFactory.createParsedStatement(stmt, ctx.getQueryOptions()); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/23005/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java: http://gerrit.cloudera.org:8080/#/c/23005/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java@41 PS1, Line 41: public CalciteParsedStatement(String stmt, TQueryOptions queryOptions) throws ImpalaException { line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7c83f9b8f1ab5885bda86cb9a1b3510f0ea05c4 Gerrit-Change-Number: 23005 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 10 Jun 2025 17:38:27 +0000 Gerrit-HasComments: Yes
