Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 )
Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/10471/3/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/10471/3/common/thrift/JniCatalog.thrift@55 PS3, Line 55: COMMENT_ON, > need comma Done http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/main/cup/sql-parser.cup@1030 PS3, Line 1030: comment_on_stmt ::= > Can you add a short comment as to why USER cannot be a keyword? Done http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/main/java/org/apache/impala/analysis/OwnerType.java File fe/src/main/java/org/apache/impala/analysis/OwnerType.java: http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/main/java/org/apache/impala/analysis/OwnerType.java@23 PS3, Line 23: > nit: Can the name be changed since it's not just type but includes the name I'll change it to Owner. http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/10471/3/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3757 PS3, Line 3757: ParserError("ALTER DATABASE SET OWNER foo"); > Add test for no parms after OWNER. Done -- To view, visit http://gerrit.cloudera.org:8080/10471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3b923021ebce5192d2d64784e7ddb952ba82bc3 Gerrit-Change-Number: 10471 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 06 Jun 2018 01:02:34 +0000 Gerrit-HasComments: Yes
