Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23017 )

Change subject: IMPALA-13945: Change hash trace to show each node's individual 
contribution
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23017/1/fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java
File fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java:

http://gerrit.cloudera.org:8080/#/c/23017/1/fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java@314
PS1, Line 314:   private boolean mergeChildImpl(String comment, TupleCacheInfo 
child, boolean mergeChildHashTrace) {
line too long (101 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53eda24e7eba264bc2d2f212b63eab9dc97a74c
Gerrit-Change-Number: 23017
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 12 Jun 2025 18:14:29 +0000
Gerrit-HasComments: Yes

Reply via email to