Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22738 )
Change subject: IMPALA-915: Cancel catalog ops for queries ...................................................................... Patch Set 8: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22738/8/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/22738/8/be/src/catalog/catalog-server.cc@551 PS8, Line 551: VLOG_RPC << "Cancel(): request=" << ThriftDebugString(req); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/22738/8/be/src/catalog/catalog-server.cc@560 PS8, Line 560: VLOG_RPC << "Cancel(): response=" << ThriftDebugStringNoThrow(resp); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. -- To view, visit http://gerrit.cloudera.org:8080/22738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab22855bd2d63b64da008b52aa33230a6f422537 Gerrit-Change-Number: 22738 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 13 Jun 2025 22:51:05 +0000 Gerrit-HasComments: Yes
