Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22913 )
Change subject: Use Google TcMalloc ...................................................................... Patch Set 7: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22913/7/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/22913/7/be/src/common/init.cc@192 PS7, Line 192: static_cast<tcmalloc::MallocExtension::BytesPerSecond>(FLAGS_memory_release_rate_bytes_per_sec)); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/22913/7/be/src/common/init.cc@194 PS7, Line 194: tcmalloc::MallocExtension::BytesPerSecond val = tcmalloc::MallocExtension::GetBackgroundReleaseRate(); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22913/7/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/22913/7/be/src/util/memory-metrics.cc@92 PS7, Line 92: std::optional<size_t> retopt = tcmalloc::MallocExtension::GetNumericProperty(tcmalloc_var_.c_str()); line too long (102 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib224895c43c59671ad58a90d1cfdea8ae7bde6e5 Gerrit-Change-Number: 22913 Gerrit-PatchSet: 7 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 14 Jun 2025 00:21:32 +0000 Gerrit-HasComments: Yes
