Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )
Change subject: IMPALA-14141: Disable auto compaction for the a table in acid.test ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23020/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23020/2//COMMIT_MSG@9 PS2, Line 9: This patch disables auto compaction for the table : 'insert_only_major_and_minor_compacted' why don't we disable hive.compactor.initiator.on globally to avoid "surprise compactions"? it's possible that only this single dataload table is impacted, but there are some tests that do compactions and the possibility of triggering this in HMS may make the flaky http://gerrit.cloudera.org:8080/#/c/23020/2/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/23020/2/testdata/datasets/functional/functional_schema_template.sql@4609 PS2, Line 4609: ALTER TABLE {db_name}{db_suffix}.{table_name} SET TBLPROPERTIES ('no_auto_compaction'='true'); > nit: IMPALA-11682 add both insert_only_minor_compacted and insert_only_majo >Can you please comment why only insert_only_major_and_minor_compacted need this probably there is some threshold, e.g. size and number of files needed to trigger compaction -- To view, visit http://gerrit.cloudera.org:8080/23020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185 Gerrit-Change-Number: 23020 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 16 Jun 2025 05:57:22 +0000 Gerrit-HasComments: Yes
