Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22969 )
Change subject: IMPALA-14066 (Part 2): Fixed rebased Kudu source code to compile ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/22969/3/be/src/kudu/util/CMakeLists.txt File be/src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/22969/3/be/src/kudu/util/CMakeLists.txt@387 PS3, Line 387: # add_library(kudu_cloud_util Can you add a comment about why this is commented out? http://gerrit.cloudera.org:8080/#/c/22969/3/be/src/kudu/util/CMakeLists.txt@697 PS3, Line 697: #ADD_KUDU_TEST(cloud/instance_detector-test) Can you add comment about this being commented out as Impala doesn't need it? -- To view, visit http://gerrit.cloudera.org:8080/22969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4c3490689d0bfb55c082af44955d43b5169dece Gerrit-Change-Number: 22969 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 16 Jun 2025 14:09:41 +0000 Gerrit-HasComments: Yes
