Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23051 )

Change subject: IMPALA-14154: IllegalStateException with Iceberg table with 
DELETE
......................................................................


Patch Set 2:

(1 comment)

Thanks for fixing this!

http://gerrit.cloudera.org:8080/#/c/23051/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java
File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java:

http://gerrit.cloudera.org:8080/#/c/23051/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@344
PS2, Line 344: The conjunct corresponding to 'joinNode' refers only to the 
tuple that corresponds
             :     // to the scan from Iceberg data files
Which conjunct are talking to here? IIUC, 'joinNode' should only have the 
'positionJoinConjuncts' that refers to both tuples. Am I missing something?



--
To view, visit http://gerrit.cloudera.org:8080/23051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2c03fe3da44dc0516ebdf32430416a1059d37b2
Gerrit-Change-Number: 23051
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Jun 2025 09:54:49 +0000
Gerrit-HasComments: Yes

Reply via email to