Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22599 )
Change subject: IMPALA-13795: Support serving webUI content with gzip compression ...................................................................... Patch Set 12: (1 comment) Please also address the line too long warnings. http://gerrit.cloudera.org:8080/#/c/22599/12/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/22599/12/be/src/util/webserver.cc@604 PS12, Line 604: // Initialize compressed_buffer_mem_tracker_, if not initialized : if (compressed_buffer_mem_tracker_.get() == nullptr) { : MemTracker* process_mem_tracker = nullptr; : if (ExecEnv::GetInstance() != nullptr) { : process_mem_tracker = ExecEnv::GetInstance()->process_mem_tracker(); : } : compressed_buffer_mem_tracker_ = std::make_shared<MemTracker>(-1, : "WebserverCompressedBuffer", process_mem_tracker); : } Move this initialization to Webserver constructor? -- To view, visit http://gerrit.cloudera.org:8080/22599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431088a30337bbef2c8d6e16dd15fb6572db0f15 Gerrit-Change-Number: 22599 Gerrit-PatchSet: 12 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Jun 2025 14:14:54 +0000 Gerrit-HasComments: Yes
