Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23071 )
Change subject: IMPALA-13985: Rename webUI's JS Tests to better fit general test naming schemes ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23071/1/tests/webui/js_tests/query_timeline/fragment_diagram.test.js File tests/webui/js_tests/query_timeline/fragment_diagram.test.js: http://gerrit.cloudera.org:8080/#/c/23071/1/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@56 PS1, Line 56: Basic Case (SvgGroup) > It may not look proper to remove all whitespaces and replace them with _, " I still think it is best to be consistent with the rest of pytest and ctest. See how it look here: https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/5824/testReport/ -- To view, visit http://gerrit.cloudera.org:8080/23071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5715d47cef5c1c3c06b4f2de7fe467aee3de8868 Gerrit-Change-Number: 23071 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Jun 2025 17:01:05 +0000 Gerrit-HasComments: Yes
