Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21760 )
Change subject: IMPALA-12349: Support Apache Hive 2.x in Impala ...................................................................... Patch Set 39: (2 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/21760/38/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/21760/38/be/src/catalog/catalog-server.cc@1208 PS38, Line 1208: // current_event.AddMember("cat_name", progress_info.current_event.catName); Why commenting out this? http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java File fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java: http://gerrit.cloudera.org:8080/#/c/21760/39/fe/src/compat-apache-hive-2/java/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java@1 PS39, Line 1: /** : * Autogenerated by Thrift Compiler (0.9.3) : * : * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING : * @generated : */ We need the license header comment or add these file names to bin/rat_exclude_files.txt -- To view, visit http://gerrit.cloudera.org:8080/21760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5f104dc8d131835b8118b9d54077471db65681c Gerrit-Change-Number: 21760 Gerrit-PatchSet: 39 Gerrit-Owner: ttttttz <2433038...@qq.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Reviewer: ttttttz <2433038...@qq.com> Gerrit-Comment-Date: Thu, 26 Jun 2025 05:20:57 +0000 Gerrit-HasComments: Yes
