Hello Tianyi Wang, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10617
to review the following change.
Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens
......................................................................
IMPALA-7012: Fix NPE when parsing unexpected tokens
Currently some token are not added to tokenIdMap in the sql scanner and
an NPE will be thrown if such are parsed as unexpected tokens. This
patch fixes this bug and adds a case to ParserTest.
Change-Id: I9c846fdfb22ba37bfc3b1985b9a044014ab58968
Reviewed-on: http://gerrit.cloudera.org:8080/10512
Reviewed-by: Tianyi Wang <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
3 files changed, 36 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/10617/1
--
To view, visit http://gerrit.cloudera.org:8080/10617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c846fdfb22ba37bfc3b1985b9a044014ab58968
Gerrit-Change-Number: 10617
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tianyi Wang <[email protected]>
