Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23096 )

Change subject: IMPALA-14187: Add IMPALA_JAVA_TARGET env var
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23096/1/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23096/1/fe/pom.xml@670
PS1, Line 670:           <target>${env.IMPALA_JAVA_TARGET}</target>
Rather than refer to the environment variable directly, we should use 
java/pom.xml to turn it into a property and reference that property here and 
elsewhere.

In some build environments, we replace all the environment variables in 
java/pom.xml with their actual value before building so that the published poms 
don't reference environment variables.



--
To view, visit http://gerrit.cloudera.org:8080/23096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If194d87c542d416b878661403c32c6adc2930199
Gerrit-Change-Number: 23096
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Thu, 26 Jun 2025 17:58:59 +0000
Gerrit-HasComments: Yes

Reply via email to