Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23097 )

Change subject: IMPALA-13235: Add OpenSSL Utility Function to Validate PEM 
Bundles
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23097/3/be/src/util/openssl-util.cc
File be/src/util/openssl-util.cc:

http://gerrit.cloudera.org:8080/#/c/23097/3/be/src/util/openssl-util.cc@180
PS3, Line 180: return OpenSSLErr("PEM_read_bio_X509", "parsing certificate from 
PEM bundle");
Any way to trigger this error in test?


http://gerrit.cloudera.org:8080/#/c/23097/3/be/src/util/openssl-util.cc@198
PS3, Line 198: ERR_clear_error();
Why this is not called when returning early in L180?



--
To view, visit http://gerrit.cloudera.org:8080/23097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e9f12e854b679ccf3e94a38c2688a7431460a7a
Gerrit-Change-Number: 23097
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: gaurav singh <[email protected]>
Gerrit-Comment-Date: Fri, 27 Jun 2025 19:34:23 +0000
Gerrit-HasComments: Yes

Reply via email to