Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22123 )
Change subject: WIP: IMPALA-13486: Support MemPool backed by BufferPool in parquet scanner ...................................................................... Patch Set 4: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22123/4/be/src/exec/hdfs-columnar-scanner.cc File be/src/exec/hdfs-columnar-scanner.cc: http://gerrit.cloudera.org:8080/#/c/22123/4/be/src/exec/hdfs-columnar-scanner.cc@322 PS4, Line 322: VLOG_QUERY << "ideal_reservation=" << ideal_io_reservation << ", total_reservation=" << context_->total_reservation(); line too long (120 > 90) http://gerrit.cloudera.org:8080/#/c/22123/4/be/src/exec/hdfs-columnar-scanner.cc@330 PS4, Line 330: int64_t reservation_to_distribute = min(ideal_io_reservation, context_->total_reservation()); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/22123/4/be/src/exec/hdfs-columnar-scanner.cc@332 PS4, Line 332: context_->total_reservation() - extra_required_reservation - bp_client_->GetUsedReservation()); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/22123/4/be/src/exec/hdfs-columnar-scanner.cc@333 PS4, Line 333: VLOG_QUERY << "reservation_to_distribute=" << reservation_to_distribute << ", total_reservation=" << context_->total_reservation(); line too long (133 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cf0eac43fa98cb4cff66e5061f5bb561487d6ab Gerrit-Change-Number: 22123 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 30 Jun 2025 03:04:09 +0000 Gerrit-HasComments: Yes
