Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23106 )
Change subject: IMPALA-14163: (Addendum) Always reset max-query-mem-limit ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py@1488 PS1, Line 1488: config.set_config_value(pool_name, config_str, 1) > What is the value of min-query-mem-limit, while we seem to set the max-quer I think my question is, based on the comment, "config.set_config_value(..., 25MB)" seems to also set min-query-mem-limit to 25MB, but "config.set_config_value(..., 1)" doesn't change min-query-mem-limit. It's not obvious where min-query-mem-limit is coming from. Maybe it's unrelated to this change since these are old values, but it might help to explicitly set min-query-mem-limit to avoid confusion or adding a comment. -- To view, visit http://gerrit.cloudera.org:8080/23106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41f671b8fb3eabf263041a834b54740fbacda68e Gerrit-Change-Number: 23106 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 02 Jul 2025 04:19:18 +0000 Gerrit-HasComments: Yes
