Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10510 )

Change subject: IMPALA-5552: Add support for authorized proxy groups
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10510/11/tests/authorization/test_authorization.py
File tests/authorization/test_authorization.py:

http://gerrit.cloudera.org:8080/#/c/10510/11/tests/authorization/test_authorization.py@200
PS11, Line 200: @pytest.mark.execute_serially
              :   @CustomClusterTestSuite.with_args("--server_name=server1\
              :         --authorization_policy_file=%s\
              :         --authorized_proxy_group_config=hue=%s\
              :         --authorized_proxy_group_config_delimiter=@\
              :         --abort_on_failed_audit_event=false\
              :         --audit_event_log_dir=%s" % (AUTH_POLICY_FILE,
              :                                      '@'.join(get_groups()),
              :                                      AUDIT_LOG_DIR))
              :   def test_group_impersonation_with_custom_delimiter(self):
              :     """End-to-end group impersonation with custom delimiter + 
authorization test"""
              :     self.__test_impersonation()
> I don't think this is required. Custom cluster tests are usually expensive 
I mean "custom delimiters are being parsed correctly."



--
To view, visit http://gerrit.cloudera.org:8080/10510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6953f89c293b06b72f523b11802232133d9d6cbb
Gerrit-Change-Number: 10510
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 21:59:10 +0000
Gerrit-HasComments: Yes

Reply via email to