Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23120 )
Change subject: IMPALA-14197: Fix NestedLoopJoin to increment ProbeRows counter ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23120/1/be/src/exec/nested-loop-join-node.cc File be/src/exec/nested-loop-join-node.cc: http://gerrit.cloudera.org:8080/#/c/23120/1/be/src/exec/nested-loop-join-node.cc@704 PS1, Line 704: probe_batch_->num_rows()) Please double check. Is probe_batch_ always empty within this block due to TransferResourceOwnership at L692? -- To view, visit http://gerrit.cloudera.org:8080/23120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98d56d010ee1367f8e96a368cbc64c02a4e390f0 Gerrit-Change-Number: 23120 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Jul 2025 17:03:52 +0000 Gerrit-HasComments: Yes