Riza Suminto has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/23071 )
Change subject: IMPALA-13985: Fix webUI JS tests naming scheme
......................................................................
IMPALA-13985: Fix webUI JS tests naming scheme
The names of webUI's JS tests seem arbitrary and vary widely from the
the general naming scheme of other test framework generated JUnitXMLs.
This patch provides consistency to the naming scheme.
All the webUI JS tests follow the following naming scheme now.
webui.js_tests.<module>.<function>.<description>
jest-junit package has been configured to use the following config -
{
"classNameTemplate": "{classname}",
"titleTemplate": "{title}",
"ancestorSeparator": "."
}
Example:
Within JUnitXML,
<testsuites ... >
...
<testsuite
name = "webui.js_tests.fragment_diagram.getSvgTests"
... >
...
<testcase
classname="webui.js_tests.fragment_diagram.getSvgTests"
name="basic_case.SvgRect"
... >
</testcase>
...
</testsuite>
...
</testsuites>
Change-Id: I5715d47cef5c1c3c06b4f2de7fe467aee3de8868
Reviewed-on: http://gerrit.cloudera.org:8080/23071
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Reviewed-by: Riza Suminto <riza.sumi...@cloudera.com>
---
M tests/webui/js_tests/package.json
M tests/webui/js_tests/queries/profileParseWorker.test.js
M tests/webui/js_tests/query_timeline/chart_commons.test.js
M tests/webui/js_tests/query_timeline/fragment_diagram.test.js
M tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js
M tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js
6 files changed, 34 insertions(+), 32 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Riza Suminto: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/23071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5715d47cef5c1c3c06b4f2de7fe467aee3de8868
Gerrit-Change-Number: 23071
Gerrit-PatchSet: 6
Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com>
